Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possible alternation between slots and prop content to arrows #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

w-etc
Copy link

@w-etc w-etc commented Feb 13, 2019

  • User can now fill slots for prevArrow and nextArrow.
  • If both props and slots are introduced to the component, slots will take priority.

This was introduced because we wanted to use custom components as arrows, which the current prop for that would not let us achieve.

@codecov-io
Copy link

Codecov Report

Merging #102 into master will increase coverage by 0.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage      78%   78.84%   +0.84%     
==========================================
  Files           1        1              
  Lines          50       52       +2     
  Branches       15       15              
==========================================
+ Hits           39       41       +2     
  Misses          7        7              
  Partials        4        4
Impacted Files Coverage Δ
src/components/Paginate.vue 78.84% <100%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16fc507...62cec50. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants