ensure extra events are serializable before uploading #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extra events may contain raw objects some of which are not serializable by msgpack. Adding json.load ensures that the frame can be sent without fail.
Update frame.py
|
Hi @gorkem2020, Thank you for submitting the PR. |
|
Hello @gorkem2020 and thanks again for the contribution! 🙌 I've noticed that your change doesn't really work for values passed in the context (only for extra). I've patched it up and updated tests. Too late I realized that you had opened a PR from your |
- formatter can still work its encoding changes - no test case update needed, only added test cases - end user functionality still remains the same (objects are serialized)
|
@gorkem2020 Thank you again for the contribution, I just released it as v0.2.9 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra events may include objects that are not serializable by msgpack and results in failure when trying to upload. Adding json.loads/dumps ensures that each extra event is serializable before uploading, so that msgpack can process