Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PUT requests #34

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Add support for PUT requests #34

merged 3 commits into from
Dec 3, 2021

Conversation

fylie
Copy link

@fylie fylie commented Aug 27, 2021

What does this PR do?

This PR adds support for the PUT HTTP request method.

Why is it important/What is the impact to the user?

Supporting PUT is important as some APIs (for example the Elasticsearch API) don't support POST/PUT interchangeably.

I noticed that there were multiple other PRs that attempted to add PUT functionality #32 and #28, but they haven't been merged due to reasons unrelated to this functionality.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 27, 2021

💚 CLA has been signed

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@jsvd jsvd merged commit f4ca8bf into logstash-plugins:main Dec 3, 2021
@jsvd
Copy link
Member

jsvd commented Dec 3, 2021

Published as logstash-filter-http-1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants