Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requirements and fix minor bug in gpt2 example #88

Closed
wants to merge 1 commit into from

Conversation

LauraRuis
Copy link
Collaborator

Just adding some requirements needed for running wiki example + fix a minor bug in train.py

@sangkeun00
Copy link
Collaborator

Hi Laura,

Thanks for fixing the bug in our GPT training code.
Regarding the requirements, dependencies like transformers and accelerate are specific to some examples (e.g. BERT, GPT), but not to analog itself. Therefore, I am inclined to include these dependencies in a separate requirements.txt in each example directory. Any thoughts?

@eatpk
Copy link
Collaborator

eatpk commented Feb 4, 2024

I've tried to address this problem here, PTAL!
#89

@sangkeun00
Copy link
Collaborator

Fixed in 21a5168

@sangkeun00 sangkeun00 closed this Feb 8, 2024
@sangkeun00 sangkeun00 deleted the laura-add-deps branch May 21, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants