Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1461][APPEND] Fix mistype of _project_id in engine/python #1364

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Jul 8, 2024

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@aversey aversey requested a review from vatj July 8, 2024 13:05
@aversey aversey self-assigned this Jul 8, 2024
@aversey aversey changed the title Fix mistype of _project_id in engine/python [FSTORE-1461][APPEND] Fix mistype of _project_id in engine/python Jul 8, 2024
@vatj vatj enabled auto-merge (squash) July 8, 2024 13:10
@vatj vatj merged commit cf4c3e0 into logicalclocks:master Jul 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants