-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSTORE-1285] Model Dependent Transformation Functions #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethmhc
reviewed
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general comments
manu-sj
force-pushed
the
FSTORE-1285
branch
2 times, most recently
from
May 28, 2024 06:25
206a533
to
92324cf
Compare
kennethmhc
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
manu-sj
force-pushed
the
FSTORE-1285
branch
2 times, most recently
from
June 11, 2024 08:08
149e0d2
to
50e944c
Compare
kennethmhc
requested changes
Jun 12, 2024
kennethmhc
approved these changes
Jun 17, 2024
…for different udf's having same statistics parameter name
… mainatin same order
… to dependencies with greater expectation
…to obtain feature names after transfromations
…e names after transfromations
…parameters and also renaming decorator name
…parameters and also renaming decorator name
…n_features and statistics_argument_names as Lists
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements model dependent transformation function as per the design log : https://hopsworks.atlassian.net/wiki/spaces/FST/pages/388464653/Model+Dependent+Transformation+Proposal+-+version+2
Changes Performed
Added decorator called
hopsworks_udf
that should be used to defined transformation functions.Added possibility to obtain statistics within transformation functions.
Added possibility for one to many and many to many transformation functions.
Transformation functions executed as
pandas_udf's
in spark engine and regular pandas functions in python engine.Added ability to attach to a feature view transformation functions that are not explicitly saved to the backend using the transformations API.
Removed attaching transformation function to training dataset features and attached transformation functions to feature view directly. Hence removed the DTO class
transformation_functions_attached
.JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1285?atlOrigin=eyJpIjoiYjYwZDAyM2ZjZjNkNDU5MWEyNmRjN2MxZjNiZmNhZmEiLCJwIjoiaiJ9
Related PRs:
How Has This Been Tested?
Checklist For The Assigned Reviewer: