Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1087] Add retries for FlightUnavailableError #1151

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

steffengr
Copy link

@steffengr steffengr commented Nov 20, 2023

I cannot figure out why get_flight_info keeps failing in some scenarios. It appears like the request does in fact not reach our code. It's either an issue in the network stack, GRPC or ArrowFlight. The best I can do is adding retires which works around the issue.

JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1087

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@steffengr steffengr changed the title [FSTORE-1087] add timeout config to get_flight_info [FSTORE-1087] Add retries for ArrowFlight get_flight_info Nov 20, 2023
@steffengr steffengr changed the title [FSTORE-1087] Add retries for ArrowFlight get_flight_info [FSTORE-1087] Add retries for FlightUnavailableError Nov 20, 2023
Copy link
Contributor

@kennethmhc kennethmhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffengr steffengr merged commit 1685adf into logicalclocks:master Nov 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants