Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSTORE-1061] Add documentation for get_feature_vector and fallback to use raw feature name #1138

Merged
merged 2 commits into from
Oct 25, 2023
Merged

[FSTORE-1061] Add documentation for get_feature_vector and fallback to use raw feature name #1138

merged 2 commits into from
Oct 25, 2023

Conversation

kennethmhc
Copy link
Contributor

This PR adds/fixes/changes...

  • please summarize your changes to the code
  • and make sure to include all changes to user-facing APIs

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

davitbzh
davitbzh approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@davitbzh davitbzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested and it works as described in Jira.

@kennethmhc kennethmhc merged commit 3d6237c into logicalclocks:master Oct 25, 2023
12 checks passed
kennethmhc added a commit to kennethmhc/feature-store-api that referenced this pull request Mar 4, 2024
@kennethmhc
[FSTORE-1061] Add documentation for get_feature_vector and fallback t…
4415cf8 
…o use raw feature name (logicalclocks#1138)

* add doc and primary key fallback

* fix style

(cherry picked from commit 3d6237c)
kennethmhc added a commit that referenced this pull request Mar 18, 2024
@kennethmhc @bubriks
[FSTORE-1061] Add documentation for get_feature_vector and fallback t…
8e0f763 
…o use raw feature name v3.4 (#1245)

* [FSTORE-1061] Add documentation for get_feature_vector and fallback to use raw feature name (#1138)

* add doc and primary key fallback

* fix style

(cherry picked from commit 3d6237c)

* pump version to 3.4.8

* [FSTORE-1193] HSFS python tests fail after moto has been updated (#1206)

(cherry picked from commit cd78490)

---------

Co-authored-by: Ralf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davitbzh davitbzh davitbzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennethmhc @davitbzh