Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-927] Upgrade great expectations to 0.15.12 #1128

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[FSTORE-927] Upgrade great expectations to 0.15.12 #1128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ def read(fname):
"avro==1.11.3",
"sqlalchemy",
"PyMySQL[rsa]",
"great_expectations==0.14.13",
"markupsafe<2.1.0", # GE issue 1: jinja2==2.11.3, pulls in markupsafe 2.1.0 which is not compatible with jinja2==2.11.3.
"great_expectations==0.15.12",
"markupsafe<2.1.0", # GE issue: jinja2==2.11.3, pulls in markupsafe 2.1.0 which is not compatible with jinja2==2.11.3.
"tzlocal",
"fsspec",
],
Expand Down
2 changes: 1 addition & 1 deletion python/tests/engine/test_spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3438,7 +3438,7 @@ def test_validate_with_great_expectations(self, mocker):
"data_asset_name": "<YOUR_MEANGINGFUL_NAME>",
},
"expectation_suite_name": "es_name",
"great_expectations_version": "0.14.13",
"great_expectations_version": "0.15.12",
"run_id": {"run_name": "test_run_id", "run_time": mocker.ANY},
"validation_time": mocker.ANY,
},
Expand Down
6 changes: 3 additions & 3 deletions python/tests/fixtures/expectation_suite_fixtures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"id": 32
}
],
"meta": "{ \"great_expectations_version\": \"0.14.13\", \"key\": \"value\" }",
"meta": "{ \"great_expectations_version\": \"0.15.12\", \"key\": \"value\" }",
"id": 21,
"data_asset_type": "test_data_asset_type",
"ge_cloud_id": "test_ge_cloud_id",
Expand Down Expand Up @@ -39,7 +39,7 @@
"id": "4"
}
],
"meta": "{\"great_expectations_version\": \"0.14.13\",\"key\": \"value\"}",
"meta": "{\"great_expectations_version\": \"0.15.12\",\"key\": \"value\"}",
"id": 21,
"data_asset_type": "test_data_asset_type",
"ge_cloud_id": "test_ge_cloud_id",
Expand Down Expand Up @@ -67,7 +67,7 @@
"id": 32
}
],
"meta": "{\"great_expectations_version\": \"0.14.13\",\"key\": \"value\"}"
"meta": "{\"great_expectations_version\": \"0.15.12\",\"key\": \"value\"}"
}
},
"get_list_empty": {
Expand Down
8 changes: 4 additions & 4 deletions python/tests/fixtures/feature_group_fixtures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"id": 32
}
],
"meta": "{ \"great_expectations_version\": \"0.14.13\", \"key\": \"value\" }",
"meta": "{ \"great_expectations_version\": \"0.15.12\", \"key\": \"value\" }",
"id": 21,
"data_asset_type": "test_data_asset_type",
"ge_cloud_id": "test_ge_cloud_id",
Expand Down Expand Up @@ -163,7 +163,7 @@
"id": 32
}
],
"meta": "{ \"great_expectations_version\": \"0.14.13\", \"key\": \"value\" }",
"meta": "{ \"great_expectations_version\": \"0.15.12\", \"key\": \"value\" }",
"id": 21,
"data_asset_type": "test_data_asset_type",
"ge_cloud_id": "test_ge_cloud_id",
Expand Down Expand Up @@ -305,7 +305,7 @@
"id": 32
}
],
"meta": "{ \"great_expectations_version\": \"0.14.13\", \"key\": \"value\" }",
"meta": "{ \"great_expectations_version\": \"0.15.12\", \"key\": \"value\" }",
"id": 21,
"data_asset_type": "test_data_asset_type",
"ge_cloud_id": "test_ge_cloud_id",
Expand Down Expand Up @@ -402,7 +402,7 @@
"id": 32
}
],
"meta": "{ \"great_expectations_version\": \"0.14.13\", \"key\": \"value\" }",
"meta": "{ \"great_expectations_version\": \"0.15.12\", \"key\": \"value\" }",
"id": 21,
"data_asset_type": "test_data_asset_type",
"ge_cloud_id": "test_ge_cloud_id",
Expand Down
6 changes: 3 additions & 3 deletions python/tests/test_expectation_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_from_response_json(self, backend_fixtures):
assert es.validation_ingestion_policy == "TEST_VALIDATION_INGESTION_POLICY"
assert len(es.expectations) == 1
assert isinstance(es.expectations[0], ge_expectation.GeExpectation)
assert es.meta == {"great_expectations_version": "0.14.13", "key": "value"}
assert es.meta == {"great_expectations_version": "0.15.12", "key": "value"}

def test_from_response_json_list(self, backend_fixtures):
# Arrange
Expand All @@ -59,7 +59,7 @@ def test_from_response_json_list(self, backend_fixtures):
assert es.validation_ingestion_policy == "TEST_VALIDATION_INGESTION_POLICY"
assert len(es.expectations) == 1
assert isinstance(es.expectations[0], ge_expectation.GeExpectation)
assert es.meta == {"great_expectations_version": "0.14.13", "key": "value"}
assert es.meta == {"great_expectations_version": "0.15.12", "key": "value"}

def test_from_response_json_basic_info(self, backend_fixtures):
# Arrange
Expand All @@ -79,7 +79,7 @@ def test_from_response_json_basic_info(self, backend_fixtures):
assert es.validation_ingestion_policy == "ALWAYS"
assert len(es.expectations) == 1
assert isinstance(es.expectations[0], ge_expectation.GeExpectation)
assert es.meta == {"great_expectations_version": "0.14.13", "key": "value"}
assert es.meta == {"great_expectations_version": "0.15.12", "key": "value"}

def test_from_response_json_list_empty(self, backend_fixtures):
# Arrange
Expand Down
Loading