[CLOUD-616] Deploy to AWS Certificate Manager #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maismail
reviewed
Sep 19, 2023
| fi | ||
| aws_region=$(echo $certificate_arn | awk -F ":" '{ print $4}') | ||
| _log_info "AWS: Importing to $certificate_arn - Region: $aws_region" | ||
| aws --region ${aws_region} acm import-certificate \ |
There was a problem hiding this comment.
It this the only permissions we need to add to the instance profile then?
There was a problem hiding this comment.
I have them documented in the JIRA https://hopsworks.atlassian.net/browse/CLOUD-616?focusedCommentId=16139
There was a problem hiding this comment.
The process is not very straightforward but I explain why on my first comment
There was a problem hiding this comment.
aha, ok, but why do we need to provide the certificate_arn to start with it?
The [Amazon Resource Name (ARN)](https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html) of an imported certificate to replace. To import a new certificate, omit this field.
https://docs.aws.amazon.com/cli/latest/reference/acm/import-certificate.html
[CLOUD-616] Modifications to certificate deployment script and a dummy service to satisfy LB health check
maismail
requested changes
Oct 19, 2023
| aws --region ${aws_region} acm import-certificate \ | ||
| --certificate-arn ${certificate_arn} \ | ||
| --certificate fileb://${working_dir}/cert.pem \ | ||
| --private-key fileb://${working_dir}/privkey.pem |
There was a problem hiding this comment.
before i forget it, we need to set the certificate-chain as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOUD-616 Modifications to certificate deployment script and a dummy service to satisfy LB health check