-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed code referencing to loft in helper.go file #2381
Merged
FabianKramm
merged 3 commits into
loft-sh:main
from
12rashic:fix_code_for_vcluster_platform
Jan 8, 2025
Merged
fixed code referencing to loft in helper.go file #2381
FabianKramm
merged 3 commits into
loft-sh:main
from
12rashic:fix_code_for_vcluster_platform
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashi Chaubal <[email protected]>
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
reviewed
Jan 7, 2025
FabianKramm
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above
Signed-off-by: Rashi Chaubal <[email protected]>
12rashic
changed the title
fixed code referencing to loft from clihelper.go & helper.go files
fixed code referencing to loft in helper.go files
Jan 7, 2025
12rashic
changed the title
fixed code referencing to loft in helper.go files
fixed code referencing to loft in helper.go file
Jan 7, 2025
@FabianKramm, |
FabianKramm
previously approved these changes
Jan 7, 2025
@12rashic seems like lint has failed, can you fix that? |
Signed-off-by: Rashi Chaubal <[email protected]>
@FabianKramm Lint issue is fixed. |
FabianKramm
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster platform was referencing to loft in helper.go files