Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed code referencing to loft in helper.go file #2381

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

12rashic
Copy link
Contributor

@12rashic 12rashic commented Jan 6, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster platform was referencing to loft in helper.go files

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit b8c2122
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/677e2e7d479a6600085328b6

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above

@12rashic 12rashic changed the title fixed code referencing to loft from clihelper.go & helper.go files fixed code referencing to loft in helper.go files Jan 7, 2025
@12rashic 12rashic changed the title fixed code referencing to loft in helper.go files fixed code referencing to loft in helper.go file Jan 7, 2025
@12rashic
Copy link
Contributor Author

12rashic commented Jan 7, 2025

@FabianKramm,
I updated the PR accordingly, can you please review it?
Thanks

FabianKramm
FabianKramm previously approved these changes Jan 7, 2025
@FabianKramm
Copy link
Member

@12rashic seems like lint has failed, can you fix that?

@12rashic
Copy link
Contributor Author

12rashic commented Jan 8, 2025

@FabianKramm Lint issue is fixed.

@12rashic 12rashic reopened this Jan 8, 2025
@FabianKramm FabianKramm merged commit 7dc2528 into loft-sh:main Jan 8, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants