Support labelSelectors to filter out services before syncing to the host cluster #2378
Conversation
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
ApsTomar
force-pushed
the
issue-1622-label-selector-in-sync-ops
branch
from
a35c144 to
9907de7
Compare
Signed-off-by: abhay.tomar <[email protected]> Signed-off-by: abhay.tomar <[email protected]> Signed-off-by: abhay.tomar <[email protected]>
Signed-off-by: abhay.tomar <[email protected]>
ApsTomar
force-pushed
the
issue-1622-label-selector-in-sync-ops
branch
from
9907de7 to
bb8ba3f
Compare
ApsTomar
changed the title
Signed-off-by: abhay.tomar <[email protected]>
| @@ -500,10 +501,21 @@ type EnableSwitchWithPatches struct { | |||
| // Enabled defines if this option should be enabled. | |||
| Enabled bool `json:"enabled,omitempty"` | |||
|
|
|||
| // Selector defines the labelSelector based filtering for syncing the resources to the host cluster. | |||
| Selector *SyncSelector `json:"selector,omitempty"` | |||
There was a problem hiding this comment.
Adding this here would also apply to other resources that use EnableSwitchWithPatches, is that wanted?
There was a problem hiding this comment.
We can have a separate object specifically for this purpose. But I've added this in EnableSwitchWithPatches, keeping in mind that it would provide us an option to enable such selector based filtering for other resources as well. And the user can user let it be empty if they don't require any filtering.
@FabianKramm If I understood this correctly then this feature enhancement which is requested is not a desirable one and hence the issue can be closed? |
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #1622
Please provide a short message that should be published in the vcluster release notes
Added a feature enhancement to support filtering out services using label selectors, in particular MatchExpressions (for eg. label/export-service NotIn ["false"]
What else do we need to know?