Validate comments in config/config.go before generating jsonschema #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n docs to hack/schema/main.go; fix sync-config-schema.yaml vcluster-config syncing Signed-off-by: Paweł Bojanowski <[email protected]>
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
cbron
reviewed
Dec 18, 2024
cbron
approved these changes
Dec 18, 2024
FabianKramm
approved these changes
Dec 18, 2024
loft-bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…n docs to hack/schema/main.go; fix sync-config-schema.yaml vcluster-config syncing (#2348) Signed-off-by: Paweł Bojanowski <[email protected]> (cherry picked from commit 4ff82b3)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
cbron
pushed a commit
that referenced
this pull request
Dec 18, 2024
…n docs to hack/schema/main.go; fix sync-config-schema.yaml vcluster-config syncing (#2348) Signed-off-by: Paweł Bojanowski <[email protected]> (cherry picked from commit 4ff82b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Please provide a short message that should be published in the vcluster release notes
Enhancement: do not allow invalid characters in config/config.go comments
What else do we need to know?