bugfix: use correct service-account-issuer in case of custom clusterDomain #2342
+436
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)resolves #2315
The PR adds the correct service account issuer to the apiserver in case custom clusterdomain is set using
networking.advanced.clusterDomain
.It also fixes _coredns.tpl in the chart to correctly use custom clusterdomain in coredns configuration.
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster was setting wrong service-account-issuer in case of custom clusterDomain.
What else do we need to know?
in case of the custom cluster domain the service account token for the vcluster pods is created with audiences
and because of the issuer set to
https://kubernetes.default.svc.cluster.local
the apiserver rejects the authentication request for the token. with the errorfor k0s setting just the clusterDomain in the config file works. and for k3s users needs to use correct settings as below