vcluster config convert statefulSet.affinity bugfix #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paweł Bojanowski <[email protected]>
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
… prune ephemeral-storage null values Signed-off-by: Paweł Bojanowski <[email protected]>
hidalgopl
added
backport-to-v0.20
FabianKramm
requested changes
Dec 16, 2024
Signed-off-by: Paweł Bojanowski <[email protected]>
FabianKramm
reviewed
Dec 18, 2024
FabianKramm
reviewed
Dec 18, 2024
FabianKramm
reviewed
Dec 18, 2024
Signed-off-by: Paweł Bojanowski <[email protected]>
FabianKramm
approved these changes
Dec 18, 2024
loft-bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* add test case reproducing convert bug Signed-off-by: Paweł Bojanowski <[email protected]> * fix vcluster config convert overwritting statefulSet affinity; do not prune ephemeral-storage null values Signed-off-by: Paweł Bojanowski <[email protected]> * do not prune default null values Signed-off-by: Paweł Bojanowski <[email protected]> * prune keys for empty maps etc. but keep them for null values Signed-off-by: Paweł Bojanowski <[email protected]> --------- Signed-off-by: Paweł Bojanowski <[email protected]> (cherry picked from commit b4baae9)
loft-bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* add test case reproducing convert bug Signed-off-by: Paweł Bojanowski <[email protected]> * fix vcluster config convert overwritting statefulSet affinity; do not prune ephemeral-storage null values Signed-off-by: Paweł Bojanowski <[email protected]> * do not prune default null values Signed-off-by: Paweł Bojanowski <[email protected]> * prune keys for empty maps etc. but keep them for null values Signed-off-by: Paweł Bojanowski <[email protected]> --------- Signed-off-by: Paweł Bojanowski <[email protected]> (cherry picked from commit b4baae9)
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
hidalgopl
added a commit
to hidalgopl/vcluster
that referenced
this pull request
Dec 18, 2024
* add test case reproducing convert bug Signed-off-by: Paweł Bojanowski <[email protected]> * fix vcluster config convert overwritting statefulSet affinity; do not prune ephemeral-storage null values Signed-off-by: Paweł Bojanowski <[email protected]> * do not prune default null values Signed-off-by: Paweł Bojanowski <[email protected]> * prune keys for empty maps etc. but keep them for null values Signed-off-by: Paweł Bojanowski <[email protected]> --------- Signed-off-by: Paweł Bojanowski <[email protected]>
FabianKramm
pushed a commit
that referenced
this pull request
Dec 18, 2024
* add test case reproducing convert bug * fix vcluster config convert overwritting statefulSet affinity; do not prune ephemeral-storage null values * do not prune default null values * prune keys for empty maps etc. but keep them for null values --------- Signed-off-by: Paweł Bojanowski <[email protected]>
FabianKramm
pushed a commit
that referenced
this pull request
Dec 19, 2024
* add test case reproducing convert bug Signed-off-by: Paweł Bojanowski <[email protected]> * fix vcluster config convert overwritting statefulSet affinity; do not prune ephemeral-storage null values Signed-off-by: Paweł Bojanowski <[email protected]> * do not prune default null values Signed-off-by: Paweł Bojanowski <[email protected]> * prune keys for empty maps etc. but keep them for null values Signed-off-by: Paweł Bojanowski <[email protected]> --------- Signed-off-by: Paweł Bojanowski <[email protected]> (cherry picked from commit b4baae9) Co-authored-by: Paweł Bojanowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-5301
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster convert config skipped statefulset affinity rules
What else do we need to know?