bugfix(cli): change process of finding specified binary releases #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
neogopher
force-pushed
the
fix-upgrade-command
branch
from
5eb2db9 to
53dd439
Compare
ThomasK33
reviewed
Dec 4, 2024
pkg/upgrade/helpers.go
Outdated
Comment on lines
19
to
21
| func fetchReleaseByTag(owner, repo, tag string) (*github.RepositoryRelease, error) { | ||
| var ( | ||
| ctx = context.Background() |
There was a problem hiding this comment.
Suggested change
| func fetchReleaseByTag(owner, repo, tag string) (*github.RepositoryRelease, error) { | |
| var ( | |
| ctx = context.Background() | |
| func fetchReleaseByTag(ctx context.Context, owner, repo, tag string) (*github.RepositoryRelease, error) { | |
| var ( |
neogopher
force-pushed
the
fix-upgrade-command
branch
from
53dd439 to
ed3c336
Compare
neogopher
added
backport-to-v0.20
ThomasK33
approved these changes
Dec 4, 2024
This was referenced Dec 4, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
ThomasK33
added a commit
that referenced
this pull request
Dec 6, 2024
[v0.20] Merge pull request #2309 from neogopher/fix-upgrade-command
ThomasK33
added a commit
that referenced
this pull request
Dec 6, 2024
[v0.21] Merge pull request #2309 from neogopher/fix-upgrade-command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-5127
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster upgrade command would fail for older releases