now handles both deprecated replicas and syncer.replicas
#1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianKramm
requested changes
Jan 26, 2024
facchettos
force-pushed
the
k3s-replicas
branch
from
9aebf40 to
c16d2bd
Compare
FabianKramm
requested changes
Jan 26, 2024
charts/k3s/values.yaml
Outdated
| @@ -253,7 +254,8 @@ rbac: | |||
| # - pods/exec | |||
|
|
|||
| # The amount of replicas to run the statefulset with | |||
| replicas: 1 | |||
| # THIS IS DEPRECATED. Please use syncer.replicas instead | |||
| # replicas: 1 | |||
There was a problem hiding this comment.
just remove this comment here completely
FabianKramm
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)part of eng-2715
Please provide a short message that should be published in the vcluster release notes
deprecates
replicasin favour ofsyncer.replicasto converge different distros configsWhat else do we need to know?