feat(cli): add ignore-not-found flag #1458
Conversation
cmd/vclusterctl/cmd/delete.go
Outdated
| if !errors.As(err, &errorNotFound) { | ||
| return err | ||
| } | ||
| vclusterFound = false |
There was a problem hiding this comment.
Why do we need to keep going here? Can we not just return nil and be done with it?
There was a problem hiding this comment.
I thought about that but then a command like
vcluster delete my-cluster --namespace my-namespace --delete-namespace --ignore-not-found
would not delete the namespace if the namespace exists but the vcluster does not.
I wanted to make sure that the namespace would also get cleaned up in such a case
There was a problem hiding this comment.
I think its okay to not delete the namespace if the vcluster doesn't exist, since that operation clearly was either aborted or the user messed somehow differently with the vcluster deployment.
There was a problem hiding this comment.
If this should become a problem, we could add that later then as well
There was a problem hiding this comment.
Okay, so keeping it as simple as possible for now, then I agree we can just return nil here and be done with it. I changed the PR accordingly
|
@mariuskimmina can you fix the lint issues? |
Signed-off-by: Marius Kimmina <[email protected]>
mariuskimmina
force-pushed
the
ignore-not-found
branch
from
fcaa801 to
656bde2
Compare
|
@FabianKramm fixed the linter issue and also squashed the commits |
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #771
Please provide a short message that should be published in the vcluster release notes
Added --ignore-not-found flag to prevent errors when the virtual cluster or the namespace was not found
What else do we need to know?
This was partially based on #989 which got closed to due to inactivity