Update translator.go #1316
Closed
Update translator.go #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianKramm
requested changes
Oct 31, 2023
There was a problem hiding this comment.
@iamujjwalrawat thanks for the PR! Seems like while refactoring a lot of logic is missing now.
|
Hi @iamujjwalrawat , while submitting a pull request, please use the description and commit message to describe the desired outcome of the change. It is not clear as to the intentions of this PR, and there is no follow-up. I am closing this PR and labelling it according to the Haktoberfest recommendations |
|
Removed the label as I did go through the PR and see some good-faith changes. Apologies. I misread the PR at first. Please let us know if you are planning to update the PR, and thank you for the PR |
|
See comment on you're other PR: #1315 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hacktoberfest submission!
im from india!
request if you merge and label it hacktoberfest accepted it would be gracious.