Skip to content

Commit

Permalink
Merge pull request #2254 from loft-sh/thomaskosiewski/eng-5011-bug-fi…
Browse files Browse the repository at this point in the history
…ps-build-of-vcluster-is-missing-the-helm-binary-and

fix(helm): Do not download helm if not needed
  • Loading branch information
cbron authored Oct 31, 2024
2 parents 54df968 + 1cabe49 commit fbda2d6
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions pkg/controllers/deploy/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,12 @@ func RegisterInitManifestsController(controllerCtx *synccontext.ControllerContex
return err
}

helmBinaryPath, err := helmdownloader.GetHelmBinaryPath(controllerCtx, log.GetInstance())
if err != nil {
return err
var helmBinaryPath string
if controllerCtx != nil && controllerCtx.Config != nil && len(controllerCtx.Config.Experimental.Deploy.VCluster.Helm) > 0 {
helmBinaryPath, err = helmdownloader.GetHelmBinaryPath(controllerCtx, log.GetInstance())
if err != nil {
return err
}
}

controller := &Deployer{
Expand Down

0 comments on commit fbda2d6

Please sign in to comment.