Merge pull request #457 from pratikjagrut/kubernetes.version.flag

fix: warn if the patch version is passed in kubernetes version flag

cmd/vclusterctl/cmd/create.go

@@ -13,6 +13,7 @@ import (
 	"github.com/loft-sh/vcluster/pkg/helm/values"
 	"github.com/loft-sh/vcluster/pkg/upgrade"
 	"github.com/loft-sh/vcluster/pkg/util"
+	"golang.org/x/mod/semver"
 
 	"github.com/loft-sh/vcluster/cmd/vclusterctl/flags"
 	"github.com/loft-sh/vcluster/cmd/vclusterctl/log"
@@ -172,7 +173,21 @@ func (cmd *CreateCmd) Run(args []string) error {
 
 	var kubernetesVersion *version.Info
 	if cmd.KubernetesVersion != "" {
-		kubernetesVersion, err = values.ParseKubernetesVersionInfo(cmd.KubernetesVersion)
+		if cmd.KubernetesVersion[0] != 'v' {
+			cmd.KubernetesVersion = "v" + cmd.KubernetesVersion
+		}
+
+		if !semver.IsValid(cmd.KubernetesVersion) {
+			return fmt.Errorf("please use valid semantic versioning format, e.g. vX.X")
+		}
+
+		majorMinorVer := semver.MajorMinor(cmd.KubernetesVersion)
+
+		if splittedVersion := strings.Split(cmd.KubernetesVersion, "."); len(splittedVersion) > 2 {
+			cmd.log.Warnf("currently we only support major.minor version (%s) and not the patch version (%s)", majorMinorVer, cmd.KubernetesVersion)
+		}
+
+		kubernetesVersion, err = values.ParseKubernetesVersionInfo(majorMinorVer)
 		if err != nil {
 			return err
 		}

go.mod

@@ -144,6 +144,7 @@ require (
 	go.uber.org/multierr v1.6.0 // indirect
 	go.uber.org/zap v1.19.1 // indirect
 	golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 // indirect
+	golang.org/x/mod v0.5.1
 	golang.org/x/net v0.0.0-20211209124913-491a49abca63 // indirect
 	golang.org/x/oauth2 v0.0.0-20210819190943-2bc19b11175f // indirect
 	golang.org/x/sys v0.0.0-20211029165221-6e7872819dc8 // indirect

go.sum

@@ -799,6 +799,8 @@ golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.4.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.4.1/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
+golang.org/x/mod v0.5.1 h1:OJxoQ/rynoF0dcCdI7cLPktw/hR2cueqYfjm43oqK38=
+golang.org/x/mod v0.5.1/go.mod h1:5OXOZSfqPIIbmVBIIKWRFfZjPR0E5r58TLhUjH0a2Ro=
 golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20180906233101-161cd47e91fd/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=