fix: syncer & services unit test

loft-sh · Nov 4, 2024 · 6cdca9b · 6cdca9b
1 parent 275c4f6
commit 6cdca9b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/pkg/controllers/resources/services/syncer_test.go b/pkg/controllers/resources/services/syncer_test.go
@@ -280,12 +280,6 @@ func TestSync(t *testing.T) {
 		ObjectMeta: vObjectMeta,
 		Spec: corev1.ServiceSpec{
 			ExternalName: "test.com",
-			Ports: []corev1.ServicePort{
-				{
-					Name: "http",
-					Port: 80,
-				},
-			},
 		},
 	}
 	vServiceNodePortFromExternal := &corev1.Service{
@@ -451,8 +445,9 @@ func TestSync(t *testing.T) {
 				syncCtx, syncer := syncertesting.FakeStartSyncer(t, ctx, New)
 				pObj := updateBackwardSpecRecreateService.DeepCopy()
 				vObj := baseService.DeepCopy()
-				_, err := syncer.(*serviceSyncer).Sync(syncCtx, synccontext.NewSyncEventWithOld(baseService.DeepCopy(), pObj, vObj, vObj))
+				result, err := syncer.(*serviceSyncer).Sync(syncCtx, synccontext.NewSyncEventWithOld(baseService.DeepCopy(), pObj, vObj, vObj))
 				assert.NilError(t, err)
+				assert.Equal(t, result.Requeue, true)
 
 				err = ctx.VirtualManager.GetClient().Get(ctx, types.NamespacedName{Namespace: vObj.Namespace, Name: vObj.Name}, vObj)
 				assert.NilError(t, err)
@@ -461,7 +456,7 @@ func TestSync(t *testing.T) {
 				assert.NilError(t, err)
 
 				pObj.Spec.ExternalName = updateBackwardSpecService.Spec.ExternalName
-				_, err = syncer.(*serviceSyncer).Sync(syncCtx, synccontext.NewSyncEventWithOld(pObj.DeepCopy(), pObj.DeepCopy(), vObj.DeepCopy(), vObj.DeepCopy()))
+				_, err = syncer.(*serviceSyncer).Sync(syncCtx, synccontext.NewSyncEventWithOld(baseService.DeepCopy(), pObj.DeepCopy(), vObj.DeepCopy(), vObj.DeepCopy()))
 				assert.NilError(t, err)
 			},
 		},

diff --git a/pkg/syncer/syncer_test.go b/pkg/syncer/syncer_test.go
@@ -391,6 +391,9 @@ func TestReconcile(t *testing.T) {
 						Namespace: namespaceInVClusterA,
 						UID:       "123",
 					},
+					Data: map[string][]byte{
+						"datakey1": []byte("datavalue1"),
+					},
 				},
 			},