Merge pull request #1371 from facchettos/etcd-ha-fix

fixed etcd ha not coming up
loft-sh · Nov 22, 2023 · 3d0498e · 3d0498e
2 parents ef319e4 + a828c21
commit 3d0498e
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/pkg/setup/initialize.go b/pkg/setup/initialize.go
@@ -3,6 +3,7 @@ package setup
 import (
 	"context"
 	"fmt"
+	"strconv"
 	"strings"
 	"time"
 
@@ -138,6 +139,17 @@ func GenerateK8sCerts(ctx context.Context, currentNamespaceClient kubernetes.Int
 		"*." + etcdService + "-headless" + "." + currentNamespace,
 	}
 
+	//expect up to 20 etcd members, number could be lower since more
+	//than 5 is generally a bad idea
+	for i := 0; i < 20; i++ {
+		// this is for embedded etcd
+		hostname := vClusterName + "-" + strconv.Itoa(i)
+		etcdSans = append(etcdSans, hostname, hostname+"."+vClusterName+"-headless", hostname+"."+vClusterName+"-headless"+"."+currentNamespace)
+		// this is for external etcd
+		etcdHostname := etcdService + "-" + strconv.Itoa(i)
+		etcdSans = append(etcdSans, etcdHostname, etcdHostname+"."+etcdService+"-headless", etcdHostname+"."+etcdService+"-headless"+"."+currentNamespace)
+	}
+
 	// generate certificates
 	err := certs.EnsureCerts(ctx, serviceCIDR, currentNamespace, currentNamespaceClient, vClusterName, certificatesDir, clusterDomain, etcdSans)
 	if err != nil {