-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POD-823: Add repo cache #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do you want to open another PR for the http2 fix or do it here?
@pascalbreuninger I'll do it here and continue to use this PR until tomorrow once testing has been complete :) So far though I have managed to get build times closer to 2 minutes by optimizing the snap shotting and skipping pushing of cache :) Once I can get the prebuild hash to play with dockerless then kaniko will be close to dind speed! |
This PR introduces a new CLI parameter
--registry-cache
to toggle the kaniko builder's cache from a local directory to a registry.Testing on my local kind cluster I have run through two workflows, after building devpod's
examples/build
(see loft-sh/devpod#1245):As you can see the remote cache has managed to save a user 50% build time when building updates to an existing image. Unfortunately the overall build time is still not great and this is a known issue - GoogleContainerTools/kaniko#875
We could switch to docker in docker, but this comes with security concerns since we will need priv permissions to access the daemon.sock :/
EDIT: Some users report http2 being the cause, GoogleContainerTools/kaniko#2751. I will try implement this and see if it improves build time.