Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add db connector #15

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add db connector #15

merged 2 commits into from
Nov 5, 2024

Conversation

rmweir
Copy link
Contributor

@rmweir rmweir commented Nov 2, 2024 •
edited
Loading

Part of ENG-5007.

ThomasK33
ThomasK33 suggested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ThomasK33 ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also have to add this feature to admin-apis/pkg/licenseapi/license_new.go

FabianKramm
FabianKramm requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@FabianKramm FabianKramm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you put the feature under pro distro it should be called in the following form: VirtualClusterProDistroDatabaseConnector since all pro distro features share that prefix

@rmweir rmweir requested a review from FabianKramm November 5, 2024 16:19
@deniseschannon deniseschannon merged commit 88dd686 into loft-sh:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianKramm FabianKramm FabianKramm approved these changes

@ThomasK33 ThomasK33 Awaiting requested review from ThomasK33

@LukasGentele LukasGentele Awaiting requested review from LukasGentele

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmweir @ThomasK33 @FabianKramm @deniseschannon