Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spotbugs feedback to workflow #552

Merged
merged 1 commit into from
Oct 9, 2021
Merged

add spotbugs feedback to workflow #552

merged 1 commit into from
Oct 9, 2021

Conversation

fgdrf
Copy link
Contributor

@fgdrf fgdrf commented Oct 8, 2021

  • executes goal spotbugs:check
  • adds report to list reported errors as feedback for pull-requests and master-builds

@fgdrf fgdrf added this to the 2.3.0 milestone Oct 8, 2021
@fgdrf
Copy link
Contributor Author

fgdrf commented Oct 8, 2021

@sschulz92 before we proceed with spotbugs fixes (see #551 and #550) I'd like to get feedback about the current state. Then we see changes/improvements on every pull-request and can avoid introducing new issues while changing existing code.

@fgdrf
Copy link
Contributor Author

fgdrf commented Oct 8, 2021

getting feedback for spotbugs increases build-time from ~3min to ~11min for the main compile-step, I guess its worth to wait a bit longer and provide details about the issues in the code-base

@fgdrf
Copy link
Contributor Author

fgdrf commented Oct 8, 2021 •
edited
Loading

Nice, current state : 350 spotbugs issues found, see https://github.com/locationtech/udig-platform/pull/552/checks?check_run_id=3843521836

Just note that we report errors only (see pom.xml for spotbugs-maven-plugin)

sschulz92
sschulz92 approved these changes Oct 9, 2021
View reviewed changes
Copy link
Contributor

@sschulz92 sschulz92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fgdrf fgdrf merged commit 497ad3c into master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sschulz92 sschulz92 sschulz92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fgdrf @sschulz92