Minor extensions in README; add simple Makefile #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview for this PR: https://ls-0nq935cqt4nms.sandbox.localstack.cloud/cloudfront/340c3397/ |
HarshCasper
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all - great job on the sample in this repo @HarshCasper , was able to run it seamlessly, and the sample app is a really nice illustration! 🚀 This PR adds a few small enhancements that may be useful when testing and demo'ing this app.
DISABLE_CUSTOM_CORS_S3=1(with the latestlocalstack/localstack-proimage). See screenshot below - was getting a CORS error in Chrome when the app attempts to open http://localhost:4566/restapis/6fql1e8ffn/test/_user_request_/listquizzes (even thoughDISABLE_CUSTOM_CORS_APIGATEWAY=1is set). Haven't dug into it in detail, but it could potentially be related to our internal service name parser. In any case, addingDISABLE_CUSTOM_CORS_S3=1seems to work, hence adding it to the docs here 👍Makefilewith some quality of life make targets (we can extend those as we go).