Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds content_access_by_path module #745

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

markconroy
Copy link
Member

Creating PR for the profile instead of LocalGov Drupal Core, see localgovdrupal/localgov_core#215


Thanks to Big Blue Door for sponsoring my time to work on this.

@finnlewis
Copy link
Member

Briefly discussing in Merge Tuesdays:

  1. would like to run this through our policy to check for bringing this into the localgov profile. Do enough councils want this by default etc.
  2. also I wanted to test and check on any potential security assumptions: if paths change for other reasons, might this give access to manage content by accident?

Tasks:

  • Finn to find the policy that Tech Group and Product Group agreed and a to docs site / link here.
  • Will to check with other councils on wants and needs.

@stephen-cox
Copy link
Member

Will has tried to ask content people about this, but has not had any responses.

@andybroomfield
Copy link
Contributor

What do I need to do to review?

@finnlewis finnlewis requested a review from willguv September 17, 2024 11:40
@andybroomfield
Copy link
Contributor

Looking at the issue, this is so it's avalible to people as part of the profile, but not installed by default.
So this PR passes in terms of adding the module, if that is aggreed can approve on that basis.

@finnlewis
Copy link
Member

Hi @willguv

Could we review the policy https://docs.localgovdrupal.org/governance/new-features-policy.html

and check in on point 1?

Also @andybroomfield want to check in on the security aspects. If paths change, does this change the access control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants