Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a simple mail notification after backups using mailx. #32

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Implemented a simple mail notification after backups using mailx. #32

merged 2 commits into from
Jul 25, 2019

Conversation

mrclschstr
Copy link
Contributor

Previous discussion see #4.

…s can be used to send mail via an external SMTP server. Syntax uniformity is questionable.
Copy link
Member

@niondir niondir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On small error. See comment.

What else comes to my mind, is that maybe only failing backups are interesting. But that's also fine as a future feature/PR.

Dockerfile Outdated
@@ -25,6 +25,7 @@ ENV \
BACKUP_CRON="0 */6 * * *" \
RESTIC_FORGET_ARGS="" \
RESTIC_JOB_ARGS=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a backslash \ is missing

Actually we could also split up in separate ENV lines again, since it does not create more layers in Docker. I'm open to both :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed that. Fixed it with 4a1a551.

@niondir niondir merged commit d10efe9 into lobaro:alpine Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants