Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do some player operations by Discord id #217

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Conversation

gausie
Copy link
Contributor

@gausie gausie commented Jun 18, 2024

  • Pull out process of identifying a player from an identifier and use across clan functions
  • Apply formatting

Copy link
Contributor

@horrible-little-slime horrible-little-slime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than getting a little bamboozled by one section of the code, LGTM

packages/oaf/src/commands/_player.ts Outdated Show resolved Hide resolved
@horrible-little-slime
Copy link
Contributor

So in retrospect I'm not actually sure these changes are good; @gausie either revert my last few changes and merge, or merge as is. Or a secret third thing! Dealer's choice!

@gausie gausie merged commit 254ca82 into main Sep 4, 2024
2 checks passed
@gausie gausie deleted the do-some-player-ops-by-discord branch September 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants