Add Snapper as a valuable familiar for copyTarget freeFightFamiliars #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revent Snapper at barf in weird circumstances
Rinn
reviewed
Sep 28, 2024
Rinn
reviewed
Sep 28, 2024
Rinn
reviewed
Sep 28, 2024
Rinn
reviewed
Sep 28, 2024
Rinn
reviewed
Sep 28, 2024
Update to main
horrible-little-slime
approved these changes
Oct 1, 2024
I've continued running this fork; when targeting Dudes it uses Snapper (expected) when targeting Goblins it does not (also expected). When targeting Hobos it does (lastly expected). Existing Gooso logic still works as well. Other free fight fams continue to be used. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
…2132) * We snapper now * Check the right part of outfit spec * I mean - I hate this solution but it does work * I like this solution a lot better actually. * Value penguin envelopes actually * When Bill asks for a thing you do it * Change value to 50,000 per bean, improve the Snapper value logic to prevent Snapper at barf in weird circumstances * Create a denominator for snapper * Better denominator * We're learning things today * restructure implementation of `excludeFamiliar` * Back to includes it is * Update packages/garbo/src/familiar/freeFightFamiliar.ts * Update packages/garbo/src/familiar/lib.ts * Update packages/garbo/src/familiar/freeFightFamiliar.ts * Better filter and recommended changes * Update packages/garbo/src/fights.ts Co-authored-by: neil <[email protected]> * Okeydoke. * Let's make Bill's change work by passing the entire fight. --------- Co-authored-by: horrible little slime <[email protected]> Co-authored-by: Joe Kirchoff <[email protected]> Co-authored-by: neil <[email protected]>
github-actions bot
pushed a commit
to Ignose/garbage-collector
that referenced
this pull request
Oct 4, 2024
…oathers#2132) * We snapper now * Check the right part of outfit spec * I mean - I hate this solution but it does work * I like this solution a lot better actually. * Value penguin envelopes actually * When Bill asks for a thing you do it * Change value to 50,000 per bean, improve the Snapper value logic to prevent Snapper at barf in weird circumstances * Create a denominator for snapper * Better denominator * We're learning things today * restructure implementation of `excludeFamiliar` * Back to includes it is * Update packages/garbo/src/familiar/freeFightFamiliar.ts * Update packages/garbo/src/familiar/lib.ts * Update packages/garbo/src/familiar/freeFightFamiliar.ts * Better filter and recommended changes * Update packages/garbo/src/fights.ts Co-authored-by: neil <[email protected]> * Okeydoke. * Let's make Bill's change work by passing the entire fight. --------- Co-authored-by: horrible little slime <[email protected]> Co-authored-by: Joe Kirchoff <[email protected]> Co-authored-by: neil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.