Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grimoirize Yachtzee #1603

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Grimoirize Yachtzee #1603

wants to merge 1 commit into from

Conversation

pstalcup
Copy link
Contributor

@pstalcup pstalcup commented Oct 4, 2023

No description provided.

@horrible-little-slime horrible-little-slime marked this pull request as draft October 6, 2023 12:55
Copy link
Contributor

@horrible-little-slime horrible-little-slime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rever, I'm making this review as a record so we can all work on this--I don't expect all of these changes to be shouldered by you, and I plan to hit several of them myself this weekend.

@@ -1505,8 +1505,8 @@ const freeFightSources = [
return true; // Get the artifact or kill the boss immediately for free
}

// Consider forcing noncombats below:
if (globalOptions.prefs.yachtzeechain) return false; // NCs are better when yachtzeeing, probably
if (realmAvailable("sleaze")) return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to do the math on this eventually but this is fine

Comment on lines +28 to +42
const meatOutfit = toSpec(
new Requirement(
[
"meat",
...(familiar.underwater || have($effect`Driving Waterproofly`) || have($effect`Wet Willied`)
? []
: ["underwater familiar"]),
],
{
forceEquip: [equipment],
preventEquip: $items`anemoney clip, cursed magnifying glass, Kramco Sausage-o-Matic™, cheap sunglasses`,
modes: equipment === $item`The Crown of Ed the Undying` ? { edpiece: "fish" } : {},
},
),
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no reason to make this start as a Requirement and then convert it to a spec, we should just make it directly as a spec

// We definitely need to be able to eat sliders and drink pickle juice
if (!realmAvailable("sleaze")) return;
function yachtzeeTasks(equipment: Item): Task[] {
const familiar = bestYachtzeeFamiliar();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in the file that this points to doesn't make sense anymore, given the cap. I think we should probably just always use the urchin and call it a day.

completed: () => get("noncombatForcerActive"),
do: () => use($item`Clara's bell`),
},
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to both be saving cinch-forces when SBB is open and not using them here. We should steamline that logic--I think not using cinch makes sense (I'm not sure if it's right, but it makes sense), but not the way things are currently set up

}
meatMood(false, 2000).execute(Math.min(jellyTurns, fishyTurns));
safeRestore();
return [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs handling for digitized embezzlers, which will ruin our parade. We dont' want to free run from them and we don't want to hit them in the sunken party yacht.

The smartest and coolest thing to do would be to add a check to the embezzler underwater code that says that if we have SBB and NC forcers, we don't get fishy during that stint, and we instead assume that we'll do the envyfish later in the day.

It would be nice if we started saving an envyfish egg for the next day. Is that a thing we can do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also kramco interpolation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also romanced embezzlers :-/

ready: () => have($item`Jurassic Parka`) && get("_spikolodonSpikeUses") < 5,
completed: () => get("noncombatForcerActive"),
do: () => {
const run = tryFindFreeRun(freeRunConstraints(false)) ?? ltbRun();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo we should make this a let variable outside, initialize it as part of the start of the task and dump it at the end. that way we can go through traditional outfit and combat code for grimoire. freecandy does this here, and it gets used here

@Rinn
Copy link
Member

Rinn commented Oct 6, 2023

Should prob move the umdLastObtained logic from fights.ts into this

@horrible-little-slime
Copy link
Contributor

(Waiting on #1609 before continuing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants