-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grimoirize Yachtzee #1603
base: main
Are you sure you want to change the base?
Grimoirize Yachtzee #1603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rever, I'm making this review as a record so we can all work on this--I don't expect all of these changes to be shouldered by you, and I plan to hit several of them myself this weekend.
@@ -1505,8 +1505,8 @@ const freeFightSources = [ | |||
return true; // Get the artifact or kill the boss immediately for free | |||
} | |||
|
|||
// Consider forcing noncombats below: | |||
if (globalOptions.prefs.yachtzeechain) return false; // NCs are better when yachtzeeing, probably | |||
if (realmAvailable("sleaze")) return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to do the math on this eventually but this is fine
const meatOutfit = toSpec( | ||
new Requirement( | ||
[ | ||
"meat", | ||
...(familiar.underwater || have($effect`Driving Waterproofly`) || have($effect`Wet Willied`) | ||
? [] | ||
: ["underwater familiar"]), | ||
], | ||
{ | ||
forceEquip: [equipment], | ||
preventEquip: $items`anemoney clip, cursed magnifying glass, Kramco Sausage-o-Matic™, cheap sunglasses`, | ||
modes: equipment === $item`The Crown of Ed the Undying` ? { edpiece: "fish" } : {}, | ||
}, | ||
), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason to make this start as a Requirement and then convert it to a spec, we should just make it directly as a spec
// We definitely need to be able to eat sliders and drink pickle juice | ||
if (!realmAvailable("sleaze")) return; | ||
function yachtzeeTasks(equipment: Item): Task[] { | ||
const familiar = bestYachtzeeFamiliar(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic in the file that this points to doesn't make sense anymore, given the cap. I think we should probably just always use the urchin and call it a day.
completed: () => get("noncombatForcerActive"), | ||
do: () => use($item`Clara's bell`), | ||
}, | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to both be saving cinch-forces when SBB is open and not using them here. We should steamline that logic--I think not using cinch makes sense (I'm not sure if it's right, but it makes sense), but not the way things are currently set up
} | ||
meatMood(false, 2000).execute(Math.min(jellyTurns, fishyTurns)); | ||
safeRestore(); | ||
return [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs handling for digitized embezzlers, which will ruin our parade. We dont' want to free run from them and we don't want to hit them in the sunken party yacht.
The smartest and coolest thing to do would be to add a check to the embezzler underwater code that says that if we have SBB and NC forcers, we don't get fishy during that stint, and we instead assume that we'll do the envyfish later in the day.
It would be nice if we started saving an envyfish egg for the next day. Is that a thing we can do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also kramco interpolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also romanced embezzlers :-/
ready: () => have($item`Jurassic Parka`) && get("_spikolodonSpikeUses") < 5, | ||
completed: () => get("noncombatForcerActive"), | ||
do: () => { | ||
const run = tryFindFreeRun(freeRunConstraints(false)) ?? ltbRun(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should prob move the umdLastObtained logic from fights.ts into this |
(Waiting on #1609 before continuing) |
No description provided.