Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sept-Ember Censer #1516

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Support Sept-Ember Censer #1516

merged 3 commits into from
Oct 22, 2024

Conversation

Alium58
Copy link
Member

@Alium58 Alium58 commented Oct 21, 2024

Description

Gets bridge parts and levels via mouthwash
Future PR can support banish and pickpocket combat items

How Has This Been Tested?

Not yet

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the main branch or have a good reason not to.

midgleyc
midgleyc previously approved these changes Oct 21, 2024
Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works as expected, looks good!

@Alium58
Copy link
Member Author

Alium58 commented Oct 21, 2024

Thanks Ryo for quick review!
D1 in normal standard seal clubber and worked as expected. Got bridge progress, got bembershoot, and got 22 or 24 cold res for mouth wash. Leveled from 3 to 7. Added debug logging to record how much cold res we have when using mouthwash

@Alium58
Copy link
Member Author

Alium58 commented Oct 22, 2024

wishing and the new debug statement worked good on D2

@Alium58 Alium58 marked this pull request as ready for review October 22, 2024 04:09
Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure the wish is necessarily worth it (we level over the course of the day, and how worthy is being a higher level earlier?), but if we expect to have wishes spare fair enough

@Alium58 Alium58 merged commit 497fe68 into main Oct 22, 2024
2 checks passed
@Alium58 Alium58 deleted the sept-ember-censer branch October 22, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants