Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buffMaintain should return true if it tried to do something #1513

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

midgleyc
Copy link
Member

@midgleyc midgleyc commented Oct 19, 2024

Description

Issues seen while testing #1331.

buffMaintain should return true if it tried to do something (looking at the useSkill / useItem behaviour). The CLI commands / visit_urls were not doing this, so do so.

Also shouldn't get the Grim Brother buff if speculating.

How Has This Been Tested?

Can't test the Grim Brother change because I don't have one. Did some more item provider runs.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the main branch or have a good reason not to.

@midgleyc midgleyc marked this pull request as ready for review October 19, 2024 17:20
Malibu-Stacey
Malibu-Stacey previously approved these changes Oct 22, 2024
@Malibu-Stacey Malibu-Stacey merged commit 9d4b878 into loathers:main Oct 22, 2024
1 check passed
@midgleyc midgleyc deleted the buff-maintain-true branch October 22, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants