Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagle scepter #1403

Open
wants to merge 117 commits into
base: main
Choose a base branch
from
Open

Eagle scepter #1403

wants to merge 117 commits into from

Conversation

dsimich
Copy link
Member

@dsimich dsimich commented Jan 3, 2024

Description

Patriotic Eagle support

  • Will visit the lowest level zone that contain one of the 3 useful buffs (Init, Item, or Meat)
  • If either the item or meat zone will be hit, will equip the eagle to get that buff
  • Will get meat buff before Nuns
  • Will get meat or item buff if the threshold isn't met in the 8-bit zone
  • Will get meat if threshold isn't met on Wall of Meat
  • Adds Red, White, and Blue Blast to sniffers
  • Need to add forcing eagle so that the banish is always available

August Scepter

  • Adds additional casts so that we use up all casts in a given day at rollover.
  • Restructured the initial call at the start of the day to be generic.

Candy Cane Sword Cane

  • No need to pull an eleven-foot pole if you have a CCSC

Other miscellaneous additions

  • Adds a new lastChance function for tasks that aren't powerlevelling related, but should be done before powerlevelling is attempted (currently only eagle screech force clear and Digital Key and Star Key)
  • Adds Phylum support for banishes at least. Not sure how sniffs, replaces, or YRs would be implemented in the game but there is the possibility to add additional .dat files.

How Has This Been Tested?

A lot of standard runs, mostly normal

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the main branch or have a good reason not to.

Copy link
Member

@Alium58 Alium58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for sticking through on this one. I want to be really sure screech's don't mess up folks day. Its a common thing when playing manually, especially when the eagle just came out. I bring up to say its a real concern we should be aware about

@@ -2886,6 +2887,12 @@ boolean L11_palindome()
total = total + item_amount($item[Photograph Of God]);
total = total + item_amount($item[Photograph Of A Dog]);

if(isBanishedPhyla($phylum[dude]) && get_property("screechCombats").to_int() > 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of checking screechCombats? Even if we can screech, there's no target in autoscend_phylums.txt to use it on and banish something besides dudes. Screech is complex though, maybe I'm missing something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When screech combats is greater than 0, that means that we have to do combat with the Eagle as our familiar. If it equals 0 that means that we can screech a new phylum. In the palindome, we target beasts to screech away to get rid of 3 of the 4 non dude monsters. Once beasts are screeched, the dudes will show back up. So if we can screech, we don't want to screech delay.

autoAdv($location[Noob Cave]);
}
}
set_property("screechDelay", false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this set should be inside an
if(screechCombats == 0)
{
adv in noob cave to banish constructs
set prop to false
}
return true;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to ensure we only clear the prop when we have banished constructs. Perhaps could even add another check to confirm constructs are banished after going to noob cave and aborting if they aren't. Perhaps abort is too strong... haven't thought too much on that. Will let you decide

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I see. I forgot the part about going to Noob Cave to screech the constructs, but that only really applies to the L7 quest where we only fight undead and this part only gets called if there's nothing else to do, which is why I moved it to the bottom

if(LX_getDigitalKey() || LX_getStarKey())
{
//If we still need the Digital Key or Star Key burn turns to get them
return true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose don't return anything here and just have a comment. This will allow proposed condition below to adv in noob cave to clear banish without going through the task list again-

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better way to do this is a while screechCombats > 0. That way it will just keep looping here until we can screech

@dsimich dsimich mentioned this pull request Sep 10, 2024
31 tasks
@@ -0,0 +1,12 @@
dude loc:The Black Forest
dude loc:Twin Peak
dude loc:The Red Zeppelin;sniffed:Red Butler;item:Glark Cable>2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

banishes override tracks (after nerf day 2024), so sniffing the red butler won't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants