LoL dailies & enabling Deck #1303

SaucedButLeaking · 2023-06-05T14:56:32Z

Description

Adding pull support for breathitin, homebodyl, and keepsake boxes since LoL has pulls left over every day. Also includes basic ("it exists") support for the 2002 catalog and an attempt to see if replica Deck "just works" (it does not)

How Has This Been Tested?

Ran it turn 0, re-entered gracefully

use 1 infinite BACON machine
You acquire BACON (100)
Preference _baconMachineUsed changed from false to true
Preference _concoctionDatabaseRefreshes changed from 36 to 37

cast 1 That's Not a Knife
You acquire an item: boot knife
Preference _discoKnife changed from false to true
> [INFO] Trying to pull 1 of Breathitin&trade;

pull: 1 Breathitin&trade;
Preference _roninStoragePulls changed from 9025 to 9025,10830
Preference _concoctionDatabaseRefreshes changed from 37 to 38
Preference auto_pulls changed from (1:infinite BACON machine:0) to (1:infinite BACON machine:0), (1:Breathitin&trade;:0)

chew 1 Breathitin&trade;
Preference breathitinCharges changed from 0 to 5
Preference _concoctionDatabaseRefreshes changed from 38 to 39
> [INFO] Trying to pull 1 of Homebodyl&trade;

pull: 1 Homebodyl&trade;
Preference _roninStoragePulls changed from 9025,10830 to 9025,10828,10830
Preference _concoctionDatabaseRefreshes changed from 39 to 40
Preference auto_pulls changed from (1:infinite BACON machine:0), (1:Breathitin&trade;:0) to (1:infinite BACON machine:0), (1:Breathitin&trade;:0), (1:Homebodyl&trade;:0)

chew 1 Homebodyl&trade;
Preference homebodylCharges changed from 0 to 11
Preference _concoctionDatabaseRefreshes changed from 40 to 41
> [INFO] Trying to pull 1 of smut orc keepsake box

pull: 1 smut orc keepsake box
Preference _roninStoragePulls changed from 9025,10828,10830 to 9025,10828,5788,10830
Preference _concoctionDatabaseRefreshes changed from 41 to 42
Preference auto_pulls changed from (1:infinite BACON machine:0), (1:Breathitin&trade;:0), (1:Homebodyl&trade;:0) to (1:infinite BACON machine:0), (1:Breathitin&trade;:0), (1:Homebodyl&trade;:0), (1:smut orc keepsake box:0)

use 1 smut orc keepsake box
You acquire raging hardwood plank (4)
You acquire an item: morningwood plank
You acquire an item: long hard screw
You acquire messy butt joint (2)
You acquire thick caulk (2)
Preference _concoctionDatabaseRefreshes changed from 42 to 43
> [INFO] Turn(0): Starting with 40 left and 16 pulls left at Level: 1
> [INFO] Encounter: 0.0   Exp Bonus: 2.1
> [INFO] Meat Drop: 50.0	 Item Drop: 45.0
> [INFO] HP: 21/21, MP: 2/2, Meat: 1982
> [INFO] Tummy: 0/15 Liver: 0/14 Spleen: 4/15
> [INFO] ML: 0 control: 0
> [INFO] Delay between adventures... beep boop... 
Preference _auto_thisLoopHandleFamiliar changed from  to false
Preference choiceAdventure1387 changed from 3 to -1
Preference _auto_bad100Familiar changed from  to false

Visiting Replica Mr. Store

graceful re-entry after the deck change didn't work:

use 1 replica Libram of Resolutions

use 1 replica Smith's Tome
> Failed to pull a Breathitin
> Failed to pull a smut orc keepsake box
> [INFO] Turn(0): Starting with 40 left and 16 pulls left at Level: 1

Checklist:

[ x ] My code follows the style guidelines of this project.
[ x ] I have performed a self-review of my own code.
[ x ] I have commented my code, particularly in hard-to-understand areas.
[ x ] I have based my pull request against the main branch or have a good reason not to.

…g troubleshooting

RELEASE/scripts/autoscend/paths/legacy_of_loathing.ash

Alium58 · 2023-06-07T18:47:21Z

RELEASE/scripts/autoscend/paths/legacy_of_loathing.ash

+		use(1, $item[Replica 2002 Mr. Store Catalog]); //get catalog credits
+	}
+
+	pullXWhenHaveY($item[Breathitin&trade;], 1, 0);


I think breath is good enough to pull for all classes but Ed. Don't recall off hand where it is located, but there is code to handle daily activities for all classes. Move breath pull to there and make sure not ed

Just using this may be a bit dangerous for all paths at the beginning of a run, because a charge will be wasted if the fight is free for some other reason and unrestricted has a ton of free kills and one of the first zones we go to is outdoors.

Moved to level_05.ash to help with finding the encryption key

Alium58 · 2023-06-07T18:50:22Z

RELEASE/scripts/autoscend/paths/legacy_of_loathing.ash

+			print("Failed to pull a Breathitin","red");
+		}
+
+	if (get_property("homebodylCharges").to_int() == 0) 


There is a function which returns number of free crafts left. Might be able to find if ya search for other places of thos hombodylCharges prop. It would be better to pull if we don't have any free crafts.

Also would be nice to put this somewhere that gets called when we attempt to craft. As is, this is only called at start of the day. What if we run out of crafts mid day. Don't recall off hand where a good spot is

Moved to level_11.ash since that's the only necessary craft I can think of

Alium58 · 2023-06-07T18:51:18Z

RELEASE/scripts/autoscend/paths/legacy_of_loathing.ash

+		}
+	}
+
+	if (get_property("chasmBridgeProgress").to_int() < 30)


Is pulling keepsake box already part of the chasm quest code? Sorry on mobile so not easy to search code

No we don't pull them atm, I also agree it would be more prudent to try and pull in level_9.ash instead.

I put a pull into level_09.ash, but left one in LoL dailies to grab one if no progress has been made on the bridge since we have dead pulls in LoL anyway

Alium58 · 2023-06-07T18:59:21Z

RELEASE/scripts/autoscend/iotms/mr2015.ash

@@ -613,6 +613,7 @@ boolean chateauPainting()

 boolean deck_available()
 {
+	//return (((item_amount($item[Deck of Every Card]) > 0) && is_unrestricted($item[Deck of Every Card]) && auto_is_valid($item[Deck of Every Card])) || ((item_amount($item[Replica Deck of Every Card]) > 0) && (in_lol())));


My guess why it doesn't work is line 783 of mr2015 has a visit url hardcoded for the normal deck item number. Very well might be something else

…esting

Alium58

Thanks for making this! Great stuff. Have a few comments but they are all minor

Alium58 · 2023-06-15T02:59:43Z

RELEASE/scripts/autoscend/quests/level_11.ash

+				use(1, $item[Homebodyl&trade;]); // get free craft charges
+				auto_log_info("Huffing some Homebodyl and hyperfocusing on kitchen-grade demolitions.","blue");	
+			}
+			else


No need to log when we can't pull it, can remove else statement

Alium58 · 2023-06-15T03:01:13Z

RELEASE/scripts/autoscend/quests/level_11.ash

@@ -2205,6 +2205,19 @@ boolean L11_mauriceSpookyraven()
 	{
 		auto_log_info("Time to cook up something explosive! Science fair unstable fulminate time!", "green");
 		ovenHandle();
+		if(freeCrafts() == 0)


It would be nice to add this to void initializeDay(int day) in autoscend.ash as well. That way at start of day will get free crafts to catch other uses of it. I don't mind keeping it here too

I see you are using dailyEvents() for breath's above. That could be a good spot too, I'd have to look into it more to decide which is better

I like dailyEvents() better

Alium58 · 2023-06-15T03:02:10Z

RELEASE/scripts/autoscend/quests/level_11.ash

@@ -2205,6 +2205,19 @@ boolean L11_mauriceSpookyraven()
 	{
 		auto_log_info("Time to cook up something explosive! Science fair unstable fulminate time!", "green");
 		ovenHandle();
+		if(freeCrafts() == 0)


beyond having no free crafts, also check `auto_is_valid($item[home...]) and we have space in spleen

as a note for later, canChew() checks auto_is_valid

RELEASE/scripts/autoscend/paths/legacy_of_loathing.ash

Alium58 · 2023-06-15T03:08:07Z

RELEASE/scripts/autoscend/iotms/mr2015.ash

+
+	string deckItemId = "";
+	if(in_lol())
+	{


add comment that this is the replica version specifically for LoL so folks know why we have this if statement

please add the same comment here that you did for deck_cheat

//replica Deck id for when in Legacy of Loathing

Alium58 · 2023-06-16T14:07:20Z

RELEASE/scripts/autoscend/paths/legacy_of_loathing.ash

+		use(1, $item[Replica 2002 Mr. Store Catalog]); //get catalog credits
+	}
+
+	if (get_property("chasmBridgeProgress").to_int() == 0)


can this be removed now that it was moved to lvl 9 code?

Alium58 · 2023-06-16T14:09:15Z

RELEASE/scripts/autoscend/paths/legacy_of_loathing.ash

@@ -215,4 +219,22 @@ void auto_LegacyOfLoathingDailies()
 	{
 		use(1, $item[replica Smith\'s Tome]); // get items
 	}
+
+	if(item_amount($item[Replica 2002 Mr. Store Catalog]) > 0)


also check prop _2002MrStoreCreditsCollected is false

speaking of which, would be good to update conditions above this as well if you are up for it.

_replicaSmithsTomeUsed and _replicaResolutionLibramUsed would be the prefs to check

Alium58 · 2023-06-16T14:10:51Z

RELEASE/scripts/autoscend/quests/level_05.ash

@@ -30,6 +30,20 @@ boolean L5_getEncryptionKey()
 		}
 	}

+	if(!isActuallyEd())


same comment as above. Add check for canChew and remove else

Alium58 · 2023-06-16T14:16:22Z

RELEASE/scripts/autoscend/quests/level_09.ash

@@ -210,6 +210,19 @@ void prepareForSmutOrcs()

 	// This adds a tonne of damage and NC progress
 	buffMaintain($effect[Triple-Sized]);
+
+	// pull a keepsake box if we can
+	pullXWhenHaveY($item[smut orc keepsake box], 1, 0);


This would be better in L9_chasmBuild(). It already has code to use keepsake boxes. Add the pull attempt right before that

Alium58 · 2023-06-16T14:17:22Z

RELEASE/scripts/autoscend/quests/level_09.ash

@@ -310,6 +323,7 @@ boolean L9_chasmBuild()
 	visit_url("place.php?whichplace=orc_chasm&action=bridge"+(to_int(get_property("chasmBridgeProgress"))));

 	// use any keepsake boxes we have
+


ah you must have been thinking about putting it here already. This is the spot attempting to pull should go

Ty for moving it to here. Also delete your if statement. It is duplicate of the next line after it

Alium58

couple more minor things, but getting close!

Alium58 · 2023-06-17T01:55:38Z

RELEASE/scripts/autoscend/quests/level_05.ash

@@ -30,6 +30,20 @@ boolean L5_getEncryptionKey()
 		}
 	}

+	if(!isActuallyEd() && canChew($item[Breathitin&trade;]) && spleen_left() >= $item[Breathitin&trade;].spleen))


extra paren at the very end causing checks to fail

Alium58 · 2023-06-17T01:56:13Z

RELEASE/scripts/autoscend/quests/level_05.ash

+			use(1, $item[Breathitin&trade;]); // get free outdoor fight charges
+			auto_log_info("Huffing some Breathitin before looking for the encryption key. That's the stuff!","blue");
+		}
+		else


no need for else

Alium58 · 2023-06-17T01:56:43Z

RELEASE/scripts/autoscend/quests/level_09.ash

@@ -310,6 +323,7 @@ boolean L9_chasmBuild()
 	visit_url("place.php?whichplace=orc_chasm&action=bridge"+(to_int(get_property("chasmBridgeProgress"))));

 	// use any keepsake boxes we have
+


Ty for moving it to here. Also delete your if statement. It is duplicate of the next line after it

RELEASE/scripts/autoscend/paths/legacy_of_loathing.ash

Alium58 · 2023-06-17T01:59:03Z

RELEASE/scripts/autoscend/iotms/mr2015.ash

+
+	string deckItemId = "";
+	if(in_lol())
+	{


please add the same comment here that you did for deck_cheat

//replica Deck id for when in Legacy of Loathing

Alium58 · 2023-06-17T01:59:52Z

RELEASE/scripts/autoscend.ash

@@ -1107,6 +1107,21 @@ boolean dailyEvents()
 		}
 	}

+	if(!isActuallyEd() && my_daycount() > 1)


Reminder to add canChew check for breath before pulling it

Alium58 · 2023-07-07T19:23:01Z

Hello! It has been a few weeks. Let me know if you have questions on my comments!

SaucedButLeaking added 5 commits June 5, 2023 09:06

adding some basic pulls to dailies for LoL

48ecccb

attempting to enable replica Deck of Every Card usage in LoL

86cfe7b

fixing pull formatting / syntax

904ad0a

super basic 2002 catalog stuff, disabling replica deck support pendin…

ac66777

…g troubleshooting

cleanup

2427e57

Alium58 reviewed Jun 7, 2023

View reviewed changes

SaucedButLeaking added 5 commits June 8, 2023 10:45

updating since to account for coinmaster updates

76640e5

moving pull logic around to where it makes more sense

fdaf10c

day -> my_daycount(), bumping since to the version used for current t…

5a46e29

…esting

commenting out catalog until the coinmaster supports it

d833153

Enabling Deck support

9993136

SaucedButLeaking changed the title ~~LoL dailies & basic 2002 catalog support~~ LoL dailies & enabling Deck support Jun 8, 2023

SaucedButLeaking changed the title ~~LoL dailies & enabling Deck support~~ LoL dailies & enabling Deck Jun 8, 2023

Alium58 reviewed Jun 16, 2023

View reviewed changes

tidying, adding checks, and moving some logic around

6398024

Alium58 reviewed Jun 17, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LoL dailies & enabling Deck #1303

LoL dailies & enabling Deck #1303

SaucedButLeaking commented Jun 5, 2023 •

edited

Loading

Alium58 Jun 7, 2023

Rinn Jun 7, 2023

SaucedButLeaking Jun 8, 2023

Alium58 Jun 7, 2023

SaucedButLeaking Jun 8, 2023

Alium58 Jun 7, 2023

Rinn Jun 7, 2023

SaucedButLeaking Jun 8, 2023

Alium58 Jun 7, 2023

Alium58 left a comment

Alium58 Jun 15, 2023

Alium58 Jun 15, 2023

Alium58 Jun 15, 2023

Alium58 Jun 16, 2023

Alium58 Jun 15, 2023

SaucedButLeaking Jun 16, 2023

Alium58 Jun 15, 2023

Alium58 Jun 17, 2023

Alium58 Jun 16, 2023

Alium58 Jun 16, 2023

Alium58 Jun 16, 2023

Alium58 Jun 16, 2023

Alium58 Jun 16, 2023

Alium58 Jun 16, 2023

Alium58 Jun 17, 2023

Alium58 left a comment

Alium58 Jun 17, 2023

Alium58 Jun 17, 2023

Alium58 Jun 17, 2023

Alium58 Jun 17, 2023

Alium58 Jun 17, 2023

Alium58 commented Jul 7, 2023

		@@ -310,6 +323,7 @@ boolean L9_chasmBuild()
		visit_url("place.php?whichplace=orc_chasm&action=bridge"+(to_int(get_property("chasmBridgeProgress"))));

		// use any keepsake boxes we have

LoL dailies & enabling Deck #1303

Are you sure you want to change the base?

LoL dailies & enabling Deck #1303

Conversation

SaucedButLeaking commented Jun 5, 2023 • edited Loading

Description

How Has This Been Tested?

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Alium58 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Alium58 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Alium58 commented Jul 7, 2023

SaucedButLeaking commented Jun 5, 2023 •

edited

Loading