Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add provideMaxMP and raise MP for ode to booze #1087

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

quarklikeadork
Copy link
Contributor

@quarklikeadork quarklikeadork commented Mar 13, 2022

add a maxMP provider
if needed try to increase max MP for ode to booze
don't ode for shotglass

How Has This Been Tested?

in run

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based by pull request against the master branch or have a good reason not to.

@quarklikeadork
Copy link
Contributor Author

quarklikeadork commented Apr 9, 2022

changing to draft waiting for PR #1112 to use its function speculatedMaximizerEquipment()

@quarklikeadork quarklikeadork marked this pull request as draft April 9, 2022 20:21
@quarklikeadork quarklikeadork changed the title increase max MP for ode to booze add provideMaxMP and raise MP for ode to booze Jun 11, 2022
@Alium58
Copy link
Member

Alium58 commented Jul 7, 2023

What do ya think? This has been in draft for a while. Is it time to close it? Do like the idea of what ya have going on

@quarklikeadork
Copy link
Contributor Author

What do ya think? This has been in draft for a while. Is it time to close it? Do like the idea of what ya have going on

I think it was draft to finish use for combat spells like yellow ray disintegrate, but the mess of yellow ray functions and speculative issues was too much. I'll undraft for what it provides, the issues with use of MP provider are already commented

@quarklikeadork quarklikeadork marked this pull request as ready for review July 15, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants