Merge branch 'feature/add-repr-transparent' into develop

lo48576 · Sep 19, 2024 · 688d345 · 688d345
2 parents 951b7af + 46f99bb
commit 688d345
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,15 @@
 
 ## [Unreleased]
 
+* Fix unsoundness of `template::UriTemplateStr`
+
+### Fixed
+* Fix unsoundness of `template::UriTemplateStr`
+    * The type should have `#[repr(transparent)]` to compile safely but did not.
+    * Any creations and uses of the value are undefined behavior without the
+      fix, while the current version of the Rust compiler seems to happen to
+      generate the expected binary (without any guarantee).
+
 ## [0.7.4]
 
 * Fix calculation of template expansion error location.

diff --git a/src/template/string.rs b/src/template/string.rs
@@ -82,6 +82,7 @@ mod owned;
 /// ```
 #[cfg_attr(feature = "serde", derive(serde::Serialize))]
 #[cfg_attr(feature = "serde", serde(transparent))]
+#[repr(transparent)]
 #[derive(PartialEq, Eq, PartialOrd, Ord, Hash)]
 pub struct UriTemplateStr {
     /// The raw string.