Changes to use the correct i2c function #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a more complete commit message: |
gustavosr8
force-pushed
the
at24mac-i2c-fix
branch
2 times, most recently
from
d148333
to
21ad5bd
Compare
When reading from an I2C EEPROM you need to write the address first, then send a restart, read the data and finish the transaction. Writing the address and reading the data in different transactions might work, but it seems to be a fragile assumption.
augustofg
force-pushed
the
at24mac-i2c-fix
branch
from
21ad5bd
to
1339826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.