First assignment #153
Open
First assignment #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerVeraDev
reviewed
Nov 29, 2021
| { | ||
| private readonly ProviderService service; | ||
| private readonly IMapper mapper; | ||
|
|
There was a problem hiding this comment.
Podes inyectar la interfaz Ilogger
Aqui un breve video, por si es la primera vez que escuchas sobre ILogger
https://www.youtube.com/watch?v=-P-MHeTZBSA&list=PLbnhLdYZXcqGJbb6qtJMalv7fh8nBxMcn&index=39
Y usarla por ejemplo, en bloques try - catch.
En que metodos que creaste pensas que pueden ir esos bloques try - catch?
|
|
||
| public string Email { get; set; } | ||
|
|
||
| // public List<Product> OfferedProducts { get; set; } |
There was a problem hiding this comment.
no es buena practica, dejar codigo comentado.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a backend service that connects to the local database to obtain information and provide CRUD operations from the Provider entity