Isidro solis #140
Open
Isidro solis #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Creación Provider (Class,DTO, Service, Controller). |
|
Creación de Provider (Class, DTO, Service, Controller). |
GerVeraDev
reviewed
Nov 23, 2021
| var result = service.GetAll(); | ||
| return mapper.Map<IEnumerable<ProviderDTO>>(result).ToList(); | ||
| } | ||
| catch (Exception) |
There was a problem hiding this comment.
Se podria loggear la Exception
| var result = service.Get(id); | ||
| return mapper.Map<ProviderDTO>(result); | ||
| } | ||
| catch (Exception) |
There was a problem hiding this comment.
Se podria loggear la Exception
| } | ||
| catch (Exception ex) | ||
| { | ||
| logger.LogCritical(ex.StackTrace); |
There was a problem hiding this comment.
Se podria usar otro metodo del logger que no sea LogCritical.
Segun tu punto de vista, cual podria ser y porque ?
| catch (Exception ex) | ||
| { | ||
| logger.LogCritical(ex.StackTrace); | ||
| return Ok(new { Success = false, Message = "The name is already in use" }); |
There was a problem hiding this comment.
Aqui, al retornar un "Ok", estas retornando un HTTP status 200 al cliente. Que no seria correcto...
Quizas este articulo te de una pista sobre que retornar ahi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creación entidad Provider, creación DTO: ProviderDTO, ProviderSearchDTO, ProviderService. ProviderController.
Issues
Aquí deberías contar si tuviste algún problema o en el caso de que reportaste un issue.
Ej:
Related to #(issue)
Fixes # (issue)
Opinion
Si querés dejar algún comentario al respecto: improvements, mistakes, weaknesses.