Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProviderController, Service, DTO #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 157 additions & 0 deletions Stock.Api/Controllers/ProviderController.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,157 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Linq.Expressions;
using AutoMapper;
using Microsoft.AspNetCore.Mvc;
using Stock.Api.DTOs;
using Stock.Api.Extensions;
using Stock.AppService.Services;
using Stock.Model.Entities;
using Microsoft.Extensions.Logging;

namespace Stock.Api.Controllers
{
/// <summary>
/// Provider endpoint.
/// </summary>
[Produces("application/json")]
[Route("api/provider")]
[ApiController]
public class ProviderController : ControllerBase
{
private readonly ProviderService service;
private readonly ILogger<ProviderController> logger;
private readonly IMapper mapper;

/// <summary>
/// Initializes a new instance of the <see cref="ProviderController"/> class.
/// </summary>
/// <param name="service">Provider service.</param>
/// <param name="mapper">Mapper configurator.</param>
/// <param name="logger">Logger service.</param>
public ProviderController(ProviderService service, IMapper mapper, ILogger<ProviderController> logger)
{
this.service = service ?? throw new ArgumentException(nameof(service));
this.mapper = mapper ?? throw new ArgumentException(nameof(mapper));
this.logger = logger ?? throw new ArgumentException(nameof(logger));
}

/// <summary>
/// Adds a provider.
/// </summary>
/// <param name="value">Provider info.</param>
/// <returns></returns>
[HttpPost]
public ActionResult Post([FromBody] ProviderDTO value)
Copy link
Collaborator

@gerardoaquino25 gerardoaquino25 Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cual es la diferencia entre usar como respuesta un ActionResult, ActionResult<ProviderDTO> y ProviderDTO? Cual te parece más adecuado?

{
TryValidateModel(value);

try
{
var provider = mapper.Map<Provider>(value);
service.Create(provider);
value.Id = provider.Id;
return Ok(new { Success = true, Message = "", data = value });
}
catch (Exception ex)
{
logger.LogCritical(ex.StackTrace);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Por qué se usa critical? ¿Por qué el mensaje de la respuesta es que ya existe si esta en un catch general?

return Ok(new { Success = false, Message = "The name is already in use" });
}
}

/// <summary>
/// Gets all providers.
/// </summary>
/// <returns></returns>
[HttpGet]
public ActionResult<IEnumerable<ProviderDTO>> Get()
{
try
{
var result = service.GetAll();
return mapper.Map<IEnumerable<ProviderDTO>>(result).ToList();
}
catch (Exception)
{
return StatusCode(500);
}
}

/// <summary>
/// Gets a provider by id.
/// </summary>
/// <param name="id">Provider id.</param>
/// <returns></returns>
[HttpGet("{id}")]
public ActionResult<ProviderDTO> Get(string id)
{
try
{
var result = service.Get(id);
return mapper.Map<ProviderDTO>(result);
}
catch (Exception)
{
return StatusCode(500);
}
}

/// <summary>
/// Updates a provider.
/// </summary>
/// <param name="id">Provider id.</param>
/// <param name="value">Provider information.</param>
[HttpPut("{id}")]
public void Put(string id, [FromBody] ProviderDTO value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que pasa si el parámetro id es distinto al del id contenido dentro del parámetro value?

{
var provider = service.Get(id);
TryValidateModel(value);
mapper.Map<ProviderDTO, Provider>(value, provider);
service.Update(provider);
}

/// <summary>
/// Deletes a provider.
/// </summary>
/// <param name="id">provider id to delete</param>
[HttpDelete("{id}")]
public ActionResult Delete(string id)
{
var provider = service.Get(id);
if (provider is null)
return NotFound();

service.Delete(provider);
return Ok(new { Success = true, Message = "", data = id });
}

/// <summary>
/// Search some providers.
/// </summary>
/// <param name="model">Provider filters.</param>
/// <returns></returns>
[HttpPost("search")]
public ActionResult Search([FromBody] ProviderSearchDTO model)
{
Expression<Func<Provider, bool>> filter = x => !string.IsNullOrWhiteSpace(x.Id);

if (!string.IsNullOrWhiteSpace(model.Name))
{
filter = filter.AndOrCustom(
x => x.Name.ToUpper().Contains(model.Name.ToUpper()),
model.Condition.Equals(ActionDto.AND));
}

if (!string.IsNullOrWhiteSpace(model.Email))
{
filter = filter.AndOrCustom(
x => x.Email.ToUpper().Contains(model.Email.ToUpper()),
model.Condition.Equals(ActionDto.AND));
}
var providers = service.Search(filter);
return Ok(providers);
}
}
}
18 changes: 18 additions & 0 deletions Stock.Api/DTOs/ProviderDTO.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
using System.ComponentModel.DataAnnotations;

namespace Stock.Api.DTOs
{
public class ProviderDTO
{

public string Id { get; set; }

[Required]
public string Name { get; set; }

public string Phone { get; set; }

public string Email{ get; set; }

}
}
12 changes: 12 additions & 0 deletions Stock.Api/DTOs/ProviderSearchDTO.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
namespace Stock.Api.DTOs
{
public class ProviderSearchDTO
{
public string Email { get; set; }

public string Name { get; set; }

public ActionDto Condition { get; set; }

}
}
6 changes: 2 additions & 4 deletions Stock.Api/MapperProfiles/ModelProfile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@ public ModelProfile()
// .ForMember(s => s.Id, opt => opt.Ignore())
// .ForMember(s => s.ProductType, opt => opt.Ignore());

// CreateMap<Provider, ProviderDTO>()
// .ReverseMap();
CreateMap<Provider, ProviderDTO>()
.ReverseMap();
}
}


}
3 changes: 2 additions & 1 deletion Stock.Api/Startup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public void ConfigureServices(IServiceCollection services)
services.Configure<DomainSettings>(Configuration.GetSection("DomainSettings"));
services.AddTransient<StoreService>();
//services.AddTransient<ProductService>();
//services.AddTransient<ProviderService>();
services.AddTransient<ProviderService>();
services.AddTransient<ProductTypeService>();
services.AddTransient<Repository.LiteDb.Configuration.ConfigurationProvider>();
services.AddTransient<ILiteConfiguration, LiteConfiguration>();
Expand All @@ -40,6 +40,7 @@ public void ConfigureServices(IServiceCollection services)
services.AddTransient<IRepository<ProductType>, BaseRepository<ProductType>>();
services.AddTransient<IRepository<Store>, BaseRepository<Store>>();


services.AddControllers();
services.AddAutoMapper(typeof(Startup).Assembly);

Expand Down
64 changes: 64 additions & 0 deletions Stock.AppService/Services/ProviderService.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
using System;
using System.Collections.Generic;
using System.Linq.Expressions;
using Stock.AppService.Base;
using Stock.Model.Entities;
using Stock.Repository.LiteDb.Interface;
namespace Stock.AppService.Services
{
/// <summary>
/// Provider service.
/// </summary>
public class ProviderService : BaseService<Provider>
{
/// <summary>
/// Initializes a new instance of the <see cref="ProviderService"/> class.
/// </summary>
/// <param name="repository">Provider repository.</param>
public ProviderService(IRepository<Provider> repository)
: base(repository)
{
}

/// <summary>
/// Creates a provider.
/// </summary>
/// <param name="entity">Provider information.</param>
/// <returns></returns>
/// <exception cref="Exception"></exception>
public new Provider Create(Provider entity)
{
if (NombreUnico(entity.Name))
{
return base.Create(entity);
}

throw new Exception("The name is already in use");
}

/// <summary>
/// Checks if the provider name is unique or not.
/// </summary>
/// <param name="name">Provider name to check.</param>
/// <returns></returns>
private bool NombreUnico(string name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta funcion es identica a la que esta en la clase StoreService. Se te ocurre alguna forma de refactorizar el codigo para evitar duplicacion?

{
if (string.IsNullOrWhiteSpace(name))
{
return false;
}

return Repository.List(x => x.Name.ToUpper().Equals(name.ToUpper())).Count == 0;
}

/// <summary>
/// Search providers.
/// </summary>
/// <param name="filter"></param>
/// <returns></returns>
public IEnumerable<Provider> Search(Expression<Func<Provider, bool>> filter)
{
return Repository.List(filter);
}
}
}