Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce operator 1 #23

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Neel-Shah-29
Copy link

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@Neel-Shah-29 Neel-Shah-29 requested a review from lmoneta as a code owner August 8, 2022 14:29
@lmoneta
Copy link
Owner

lmoneta commented Aug 9, 2022

@Neel-Shah-29 : can you please fix these conflict so I can test the Reduce operator ?
Thank you

@Neel-Shah-29
Copy link
Author

@Neel-Shah-29 : can you please fix these conflict so I can test the Reduce operator ? Thank you

Done with the changes sir now you can review it once

@lmoneta
Copy link
Owner

lmoneta commented Aug 16, 2022

@Neel-Shah-29 : can you please fix the conflicts with respect to the new master ?
Sorry for this..

Copy link
Owner

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments on fixing the generated code.

tmva/sofie/inc/TMVA/ROperator_Reduce.hxx Outdated Show resolved Hide resolved
tmva/sofie/inc/TMVA/ROperator_Reduce.hxx Outdated Show resolved Hide resolved
tmva/sofie/inc/TMVA/ROperator_Reduce.hxx Outdated Show resolved Hide resolved
tmva/sofie/inc/TMVA/ROperator_Reduce.hxx Outdated Show resolved Hide resolved
tmva/sofie/inc/TMVA/ROperator_Reduce.hxx Outdated Show resolved Hide resolved
@Neel-Shah-29
Copy link
Author

Done with the changes sir but i am facing some errors with the generated code as mentioned in the image below.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants