-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue17 #133
base: master
Are you sure you want to change the base?
Issue17 #133
Conversation
ready |
<% question = Question.find_by_id(id) %> | ||
<% collaborators = question.question_collaborators %> | ||
|
||
<%= question_id_link(question) %><% if first_call %><br/><% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe child_question would make more sense than first_call
Add to the top of file : <% child_question ||= false %>
if first_call becomes unless child_question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well
I was just trying to get only one level of the child question
you way probably makes more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, let me try your way and see how it goes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember we are not supposed to allow a multipart to be a child of another multipart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the way the code is right now, quadbase will not allow a multipart question to be added on to another multipart question, so no worries
Do these changes and this should be ready to merge. |
@Dantemss - status on this request? |
@jpslav looks good. I would suggest not merging the schema.rb file though, if you can help it. |
I will make another pull request to fix the schema |
Don't make a new pull request, just commit and push to this branch. |
^ |
tell me what you think of how the attribution looks |
@jpslav Good to pull |
Fills in the attribution dialog box in projects
basically copied attribution from elsewhere