Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue17 #133

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Issue17 #133

wants to merge 16 commits into from

Conversation

zapcannon99
Copy link

Fills in the attribution dialog box in projects
basically copied attribution from elsewhere

@zapcannon99
Copy link
Author

issue #48 needs to be included in this, so let me finish issue #48, merge it with this, and make a single pull request to make it easier for you

@zapcannon99
Copy link
Author

#17, #24

@zapcannon99
Copy link
Author

ready

<% question = Question.find_by_id(id) %>
<% collaborators = question.question_collaborators %>

<%= question_id_link(question) %><% if first_call %><br/><% end %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe child_question would make more sense than first_call

Add to the top of file : <% child_question ||= false %>

if first_call becomes unless child_question

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well
I was just trying to get only one level of the child question

you way probably makes more sense

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, let me try your way and see how it goes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember we are not supposed to allow a multipart to be a child of another multipart.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the way the code is right now, quadbase will not allow a multipart question to be added on to another multipart question, so no worries

@Dantemss
Copy link
Member

Do these changes and this should be ready to merge.

@jpslav
Copy link
Member

jpslav commented Jul 20, 2012

@Dantemss - status on this request?

@Dantemss
Copy link
Member

@jpslav looks good. I would suggest not merging the schema.rb file though, if you can help it.

@zapcannon99
Copy link
Author

I will make another pull request to fix the schema

@Dantemss
Copy link
Member

Don't make a new pull request, just commit and push to this branch.

@zapcannon99
Copy link
Author

^
That's what I meant T__T

@zapcannon99
Copy link
Author

tell me what you think of how the attribution looks

@Dantemss
Copy link
Member

@jpslav Good to pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants