Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversation id to metagen request #3598

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Add conversation id to metagen request #3598

merged 1 commit into from
Nov 2, 2024

Conversation

BoABC
Copy link
Contributor

@BoABC BoABC commented Oct 25, 2024 •
edited
Loading

Why are these changes needed?

Slightly change metagen request format and add conversation id to metagen request.

Checks

  • [ x] I've made sure the relevant tests are passing (if applicable).

Tested this change on the legacy commit by

python -m fastchat.serve.gradio_web_server --controller "" --share --register new_api_endpoints.json

It seems the cmd is broken in the most recent commit though.

@infwinston infwinston merged commit 185e1a9 into lm-sys:main Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infwinston infwinston infwinston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoABC @infwinston