Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradio web server demo error #3596

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Conversation

tsunghan-wu
Copy link

@tsunghan-wu tsunghan-wu commented Oct 22, 2024

Why are these changes needed?

A quick fix for the single-model Gradio web server. The original code was passing a list to the Context object, which caused an AttributeError. This PR corrects that issue by ensuring the proper Context object is passed.

Related issue number (if applicable):

#3595

Checks:

  • I've run format.sh to lint the changes in this PR.
  • I've included any necessary doc changes. (No doc changes required.)
  • I've ensured that the relevant tests are passing (if applicable).

Test:

Follow the instructions here, and the error no longer occurs after running the controller, model worker, and Gradio worker, then opening the browser.

tsunghan-wu and others added 30 commits October 22, 2024 21:56
…ch trial, and make sure our code aligns with the format
…n-wu/FastChat into handle_function_native_multiturn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants