[CIR][CIRGen][Builtin] Support __builtin___memmove_chk #1106
Conversation
There was a problem hiding this comment.
I don't think testing the LLVM output is super valuable here, because I assume the cir.libc.memmove -> llvm memmove intrinsic lowering is already tested somewhere else, and there's nothing interesting on the LLVM lowering side beyond that. I'm fine leaving those in though.
| @@ -345,6 +345,18 @@ RValue CIRGenFunction::emitRotate(const CallExpr *E, bool IsRotateRight) { | |||
| return RValue::get(r); | |||
| } | |||
|
|
|||
| static bool isMemBuiltinOutOfBoundPossible(const CallExpr *expr, | |||
| clang::CIRGen::CIRGenModule &cgm, | |||
There was a problem hiding this comment.
Maybe we can take the ASTContext as a parameter instead of the cgm, since that's all we're using? That'll let us potentially share this helper with CodeGen in the future.
There was a problem hiding this comment.
yeah, it's a good idea, will change it. Also, now looking at it. I'm also thinking maybe I should pass argument expr of dstsize and size as parameters, instead of passing CallExpr so we have to do E->getArg(2) which assumes that size and dst size are 3rd and 4th argument.
No description provided.