[InstanceChoice] Add a default override for unspecified options #7955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Dec 5, 2024
| @@ -876,6 +876,10 @@ def SpecializeOption : Pass<"firrtl-specialize-option", "firrtl::CircuitOp"> { | |||
| }]; | |||
| let constructor = "circt::firrtl::createSpecializeOptionPass()"; | |||
|
|
|||
| let options = [ | |||
| Option<"selectDefault", "specialize-to-default-if-no-override", "bool", "false", | |||
There was a problem hiding this comment.
Can the option name (both CLI and variable) be more descriptive than just "specialize"? This is a term that is used also for layers and could mean (roughly) and removal of a parameter. Or: include instance choice in the name.
There was a problem hiding this comment.
Renamed both to be a bit more descriptive. Hopefully its not too long,
select-default-for-unspecified-instance-choice
There was a problem hiding this comment.
SGTM. Overly descriptive and obvious is fine-by-me. 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an override that, instead of emitting an error, selects the default target to specialize an instance choice when the option is unspecified.
By default a partially specified instance choice is not allowed. But we can override the error and select the default target, by using
--specialize-to-default-if-no-overridewithfirtool.This enables a user to specialize the instance choice for a particular build flow, and fall-back to the default for all others.
Relevant discussion: #7933