Fix sign handling of alias types for binary operators and casts #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated IR for some of the AST nodes handled by `MLIRScanner::VisitBinaryOperator()` and `MLIRScanner::VisitCastExpr()` depends on the sign of the operand or result types. Some of these checks attempt to directly cast the result of `Expr::getType()` to `BuiltinType` and then check if the resulting `QualType` is a signed or unsigned integer type. If the cast fails, the type is assumed to be signed. However, the type being checked may not directly be a builtin type (e.g., it may be an alias for an unsigned type wrapped in a `TypedefType`) and the default assumption may not hold. Examining the canonical type retrieved via `QualType::getCanonicalType()`, as implemented by this change, solves the issue.
|
Kindly asking if anyone is in for a review of this PR. Considering the contributions to the affected files, maybe @wsmoses? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated IR for some of the AST nodes handled by
MLIRScanner::VisitBinaryOperator()andMLIRScanner::VisitCastExpr()depends on the sign of the operand or result types. Some of these checks attempt to directly cast the result ofExpr::getType()toBuiltinTypeand then check if the resultingQualTypeis a signed or unsigned integer type. If the cast fails, the type is assumed to be signed.However, the type being checked may not directly be a builtin type (e.g., it may be an alias for an unsigned type wrapped in a
TypedefType) and the default assumption may not hold.Examining the canonical type retrieved via
QualType::getCanonicalType(), as implemented by this change, solves the issue.