rework #![no_std] support, switch on alloc
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the uses of `std` in the crate are of `Vec`, `String`, and
`Box`, which are in `alloc`, which is available on `#![no_std]`
platforms via `extern crate alloc;`. This commit adjusts these uses to
use `alloc` directly and adds an `"alloc"` feature flag to control them.
The notable exceptions still requiring a `std` flag are `HashMap` and
`HashSet` (I'm working on a separate change to add `BTree{Map,Set}`
support for `#![no_std]` envs). `frunk_core` no longer needs a `std`
flag: it has been removed.
The reimport of `core` as `std` (see lloydmeta#220 for historical explanation) is
converted to direct usage of `core` everywhere.
Removed `#[cfg(feature = "std")]` condition from `frunk_laws` and made
it depend on `frunk/std` -- it depends on `quickcheck`, which requires
`std`.
Added `#[cfg(test)] extern crate std;` to `#![no_std]` crates, as `std`
is required to run the libtest harness.
Tested working against all the combinations of feature flags I could
think of.
|
Thanks for this; I'll review more once I get a chance, but IIUC this should probably result in at least a minor version bump right? |
|
Yeah, everything other than removing the |
lloydmeta
approved these changes
Aug 3, 2024
|
Thanks for this. Just cut a new release for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got around to change I brought up in #220. See also #233.
Most of the uses of
stdin the crate are ofVec,String, andBox, which are inalloc, which is available on#![no_std]viaextern crate alloc;. This commit adjusts these uses to useallocdirectly and adds anallocfeature flag to control them. The notable exceptions still requiring astdflag areHashMapandHashSet(I'm working on a separate change to addBTree{Map,Set}support for#![no_std]envs).frunk_coreno longer needs astdflag: it has been marked deprecated with a comment.The reimport of
coreasstd(see #220 for historical explanation) is converted to direct usage ofcoreeverywhere.Removed
#[cfg(feature = "std")]condition fromfrunk_lawsand made it depend onfrunk/std-- it depends onquickcheck, which requiresstd.Added
#[cfg(test)] extern crate std;to#![no_std]crates, asstdis required to run the libtest harness.Tested against all the combinations of feature flags I could think of. Successfully compiles into a
#![no_std]embedded project withallocenabled.